Improve pricing options flexibility #2504
Conversation
softr8
force-pushed
the
feature/improve-pricing-options
branch
from
2329719 to
6626470
Compare
| subject { described_class.from_context(view_context) } | ||
|
|
||
| context "if the store has not defined default_currency" do | ||
| let(:store) { FactoryBot.create :store, default_currency: nil , cart_tax_country_iso: nil} |
There was a problem hiding this comment.
Space found before comma.
Space missing inside }.
| @@ -68,6 +68,29 @@ | |||
| end | |||
| end | |||
|
|
|||
| context ".from_context" do | |||
| let(:view_context) { double(ApplicationController, current_store: store)} | |||
softr8
force-pushed
the
feature/improve-pricing-options
branch
from
6626470 to
73a3bcc
Compare
|
Done @mamhoff, let me know what you think now... Thanks! |
|
Looks good, but can you look into the failing spec? |
|
Hm. The spec failure fix makes me wary. Why do the first two commits change the return value of |
|
Actually, the failing spec was a test that sometimes fails, I saw it red in other PR's. My guess is that a simple rebuild would've made it green. I didn't change |
|
Any comment @mamhoff ? I can rollback the view change if you feel it is not that safe. |
softr8
force-pushed
the
feature/improve-pricing-options
branch
from
3b365ab to
9ebda2f
Compare
softr8
force-pushed
the
feature/improve-pricing-options
branch
from
9ebda2f to
1606b79
Compare
| subject { described_class.from_context(view_context) } | ||
|
|
||
| context "if the store has not defined default_currency" do | ||
| let(:store) { FactoryBot.create :store, default_currency: nil , cart_tax_country_iso: nil } |
There was a problem hiding this comment.
Layout/SpaceBeforeComma: Space found before comma.
softr8
force-pushed
the
feature/improve-pricing-options
branch
from
1606b79 to
051e470
Compare
softr8
force-pushed
the
feature/improve-pricing-options
branch
from
051e470 to
f34064b
Compare
|
@jtapia Hey I think this is a great change, can you please rebase against master? |
|
@softr8 thanks for this PR 👏 |
softr8
force-pushed
the
feature/improve-pricing-options
branch
from
f34064b to
dc40bc9
Compare
|
Rebased! |
|
Thanks @softr8 !! |
The last piece, I think, to make pricing options totally flexible is to allow how it's built from a view context, allowing developers to decide how to find the prices based, example: users role
It also adjusts the API to use
object.price_for(current_pricing_options)I can add tests if you think this is a good idea.